[new release] reason-react (2 packages) (0.17.0) - #29132
Merged
Merged
Conversation
CHANGES: * Upgrade `ppxlib` lower bound to `0.36` (@anmonteiro in reasonml/reason-react#883)
Removed unnecessary dependencies for the reason-react package.
Removed the '@runtest' command from the opam file.
jmid
reviewed
Dec 28, 2025
jmid
left a comment
jmid
left a comment
Member
There was a problem hiding this comment.
Thanks!
There are 3 revdeps failures:
- melange-testing-library.0.1.0 (failed:
mel.send.pipe' has been removed. Use@mel.send' with the@mel.thismarker instead.) - server-reason-react.0.4.0 (failed: This variant pattern is expected to have type Ppxlib.expression_desc)
- styled-ppx.0.56.0 (failed: server-reason-react.0.4.0 failed to build)
I suppose we are missing a couple of bounds?
Member
|
we should be able to merge this right after #29178 goes in |
Member
|
Thanks! You may want to announce this on https://discuss.ocaml.org, where we have a Community category and an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason bindings for React.js
CHANGES:
ppxliblower bound to0.36(@anmonteiro in reason-react-ppx: upgrade ppxlib to 0.36 reasonml/reason-react#883)